Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing content resource test #13200

Merged
merged 6 commits into from
Dec 11, 2017
Merged

Fixing content resource test #13200

merged 6 commits into from
Dec 11, 2017

Conversation

jdotcms
Copy link
Contributor

@jdotcms jdotcms commented Dec 11, 2017

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2017 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ oswaldogallango
❌ Jonathan

Jonathan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

dev-dotcms
dev-dotcms reviewed Dec 11, 2017
View reviewed changes
dotCMS/src/main/java/com/dotmarketing/startup/runonce/Task04305UpdateWorkflowActionTable.java
} catch (SQLException e) {
dc.setSQL(this.createIntermediateTableForeignKeyActionId()).loadResult();
dc.setSQL(this.createIntermediateTableForeignKeyStepId()).loadResult();
} catch (Exception e) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Catch a list of specific exception subtypes instead. rule

@dev-dotcms
Copy link

SonarQube analysis reported 1 issue

  • MINOR 1 minor

Watch the comments in this conversation to review them.

@dsilvam dsilvam merged commit 551482e into master Dec 11, 2017
@dsilvam dsilvam deleted the fixing-content-resource-test branch December 11, 2017 17:45
@jgambarios jgambarios mentioned this pull request Dec 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dev-dotcms dev-dotcms dev-dotcms left review comments

@dsilvam dsilvam dsilvam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdotcms @CLAassistant @dev-dotcms @dsilvam